Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plan for you to support MiniCssExtractPlugin for Webpack 4? #10

Open
rg-najera opened this issue Jul 31, 2018 · 5 comments
Open

Any plan for you to support MiniCssExtractPlugin for Webpack 4? #10

rg-najera opened this issue Jul 31, 2018 · 5 comments

Comments

@rg-najera
Copy link

As per per extract-text-webpack-plugin readme "Since webpack v4 the extract-text-webpack-plugin should not be used for css. Use mini-css-extract-plugin instead."

This plugin might become absolute as a result, been enjoying using it when matching animations to load times and the like. Thanks for contributing to the community.

@sheerun
Copy link
Owner

sheerun commented Aug 10, 2018

I think it should just work

@nodabladam
Copy link

I am messing around with linaria and my css isn't reloading on changes. Looking around for potential solutions I saw this but am getting some warnings:

(node:28964) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead

If extracted-loader is still recommended, it would probably be good to make it work with mini-css-extract-plugin.

@sheerun
Copy link
Owner

sheerun commented Mar 5, 2020

@nodabladam I can try to fix it if you setup example repository that reproduces issue

@nodabladam
Copy link

@sheerun For me when I just run the current with-next example here without any changes (other than adding cross-env to build) I get the problem trying to build:

C:\...\extracted-loader\examples\with-next>npm run build

> [email protected] build C:\Users\enalm\code\public\extracted-loader\examples\with-next
> cross-env NODE_ENV=production next build && next export && node bin/bundle

(node:13440) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
(node:13440) DeprecationWarning: Tapable.apply is deprecated. Call apply on the plugin directly instead
Creating an optimized production build ..C:\...\extracted-loader\examples\with-next\node_modules\webpack\lib\Chunk.js:866
                throw new Error(
                ^

Error: Chunk.entrypoints: Use Chunks.groupsIterable and filter by instanceof Entrypoint instead

@sheerun
Copy link
Owner

sheerun commented Mar 5, 2020

current example is probably out of date, I'd need to create new one from scratch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants