Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin doesn't work with pagination #1

Open
natelandau opened this issue Jan 4, 2014 · 14 comments
Open

plugin doesn't work with pagination #1

natelandau opened this issue Jan 4, 2014 · 14 comments

Comments

@natelandau
Copy link

Shigeya

thanks for this plugin. it was working perfectly until i turned on pagination in my jekyll 1.4.2 site. Adding any pagination numeral to _config.ym, say, paginaion:5 immediately causes an error on building the site. Generating... error: no implicit conversion of nil into String. Removing your plugin makes this error disappear.

I am far from a programmer and I'm at a loss.

Thanks for making your amazing plugin available

@shigeya
Copy link
Owner

shigeya commented Jan 4, 2014

Hi. Let me look into the problem. I haven't used pagination in my sites so haven't realized this.

@mhulse
Copy link

mhulse commented Jan 5, 2014

+1 for pagination.

@shigeya
Copy link
Owner

shigeya commented Jan 6, 2014

OK. It must be easy to fix but I don't have spar time to work on this till weekend. Let me work on this in this weekend.

@mhulse
Copy link

mhulse commented Jan 6, 2014

Not sure if it will help you, but I just found this:

https://github.com/ilyakhokhryakov/jekyll-tagging-pagination

... for tags, but it's pretty easy to modify for categories too.

Thanks for sharing your code @shigeya!!!!! 👍

@shigeya
Copy link
Owner

shigeya commented Jan 12, 2014

Hi. I guess that it looks like this is not this plugin's problem. Could you try run jekyll with --trace flag, provide the output? you can post to gist.github.com and paste the link here. Note that in my environment adding paginate: 5 do not cause error. Also, I assume you're configuring paginate not pagination in _config.yaml (ref: http://jekyllrb.com/docs/pagination/)

@mhulse
Copy link

mhulse commented Jan 13, 2014

Oh yah? Nice! Personally, I saw this issue and assumed pagination didn't work. Thanks for testing @shigeya!

@gpxl
Copy link

gpxl commented Jan 14, 2014

I'm seeing the same issue with paginate set in Jekyll 1.4.2.

@shigeya
Copy link
Owner

shigeya commented Jan 15, 2014

@gpxl @mhulse As I said, I can't reproduce here. So, please provide stack trace, by running jekyll with --trace option and provide the trace as gist. I'm willing to help. If the trace is not large, you can directly paste here too. thanks.

@gpxl
Copy link

gpxl commented Jan 15, 2014

Here's a gist with the output I'm seeing as well as the _config.yml file I'm using. Not sure how much it will help since it doesn't trace back to the plugin directly. I ended up rolling my own plugin, but I'm up to test a fix if you need.

https://gist.github.com/gpxl/8430738

@shigeya
Copy link
Owner

shigeya commented Jan 15, 2014

Thanks. hmm. Right, it looks like the exception is not directly related to my plugin...

@greyshi
Copy link

greyshi commented Feb 11, 2014

The error arises only when your plugin is in use. With it enabled and paginate set in config.yml, I get this error:
Generating... error: no implicit conversion of nil into String. Use --trace to view backtrace

Disabling pagination or the plugin both resolve the error. Here's the stacktrace.

@shigeya
Copy link
Owner

shigeya commented Feb 12, 2014

Thanks. Let me look into this, but please don't expect answer soon. (I'm really busy at this moment..)

@minixalpha
Copy link

I have the same problem when I use another plugin jekyll-monthly-archive-plugin
with jekyll 1.4.2. When I change jekyll to version 1.2.0,the error "Generating... error: no implicit conversion of nil into String. " disappears.

@shigeya
Copy link
Owner

shigeya commented Feb 15, 2014

Ah, @minixalpha, thanks. Good point. I haven't stated about the version I'm using. I'm using 1.4 and later, and only tested against 1.4 series.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants