Skip to content
This repository has been archived by the owner on Jun 4, 2024. It is now read-only.

Docker commands in Eth2fuzz Makefile to flexibly handle interactive terminals #65

Open
gnattishness opened this issue Sep 1, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gnattishness
Copy link
Member

Is your feature request related to a problem? Please describe.

When running eth2fuzz in an interactive terminal, I can't use Ctrl-C to stop the container.

I currently need to use docker stop $CONTAINER_ID to stop fuzzing.

Describe the solution you'd like

Makefile to detect if it's in an interactive terminal, and pass appropriate -it to docker

Alternatively have a Makefile variable that can be set to enable/disable interactive docker run

Additional context

The interactive -it was previously removed, to allow people to more easily run eth2fuzz in remote terminals with nohup to protect against disconnections.

@gnattishness gnattishness changed the title Docker commands in Eth2fuzz Makefile to Docker commands in Eth2fuzz Makefile to flexibly handle interactive terminals Sep 1, 2020
@gnattishness gnattishness added enhancement New feature or request good first issue Good for newcomers labels Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant