From 03b98d336ecb724aedb0f8511155e085532a040d Mon Sep 17 00:00:00 2001 From: briskt <3172830+briskt@users.noreply.github.com> Date: Mon, 10 Feb 2025 17:02:58 +0800 Subject: [PATCH] added some clarifying comments --- application/common/components/Emailer.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/application/common/components/Emailer.php b/application/common/components/Emailer.php index f72f672c..d4b72ba5 100644 --- a/application/common/components/Emailer.php +++ b/application/common/components/Emailer.php @@ -802,6 +802,7 @@ public function sendPasswordExpiringEmails() /** @var Password $userPassword */ $userPassword = $user->currentPassword; if ($userPassword) { + // password expiry still needs to be checked because it can be extended by having an active MFA $passwordExpiry = strtotime($userPassword->getExpiresOn()); if ($passwordExpiry < strtotime(self::PASSWORD_EXPIRING_CUTOFF) && !($passwordExpiry < time()) @@ -856,6 +857,7 @@ public function sendPasswordExpiredEmails() /** @var Password $userPassword */ $userPassword = $user->currentPassword; if ($userPassword) { + // password expiry still needs to be checked because it can be extended by having an active MFA $passwordExpiry = strtotime($userPassword->getExpiresOn()); if ($passwordExpiry < time() && $passwordExpiry > strtotime(self::PASSWORD_EXPIRED_CUTOFF)