Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error message : Found invalid noise register setting of 8 #2

Open
bhrousseau opened this issue Feb 14, 2024 · 0 comments
Open

Comments

@bhrousseau
Copy link

When using vgmpacker, a wrong error message is printed on each run :

"Found invalid noise register setting of 8"

It's because the value 8 is used as an end marker :

		# Add EOF marker (0x08) to tone3 byte stream
		output_blocks[6].append(0x08)	# 0x08 is an invalid noise tone.

The code that checks invalid noise settings should take care of this EOF marker, or the check should be removed.

		# check there's no odd noise settings
		if True:
			invalid_noise_range = False
			for n in range(len(registers[6])):
				noise = registers[6][n]
				if noise > 7:
					print(" - Found invalid noise register setting of " + str(noise) + ", at offset " + str(n))
					invalid_noise_range = True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant