You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using vgmpacker, a wrong error message is printed on each run :
"Found invalid noise register setting of 8"
It's because the value 8 is used as an end marker :
# Add EOF marker (0x08) to tone3 byte stream
output_blocks[6].append(0x08) # 0x08 is an invalid noise tone.
The code that checks invalid noise settings should take care of this EOF marker, or the check should be removed.
# check there's no odd noise settings
if True:
invalid_noise_range = False
for n in range(len(registers[6])):
noise = registers[6][n]
if noise > 7:
print(" - Found invalid noise register setting of " + str(noise) + ", at offset " + str(n))
invalid_noise_range = True
The text was updated successfully, but these errors were encountered:
When using vgmpacker, a wrong error message is printed on each run :
"Found invalid noise register setting of 8"
It's because the value 8 is used as an end marker :
The code that checks invalid noise settings should take care of this EOF marker, or the check should be removed.
The text was updated successfully, but these errors were encountered: