Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add movement to starting position in seq.scan() #190

Open
BrianJKoopman opened this issue Dec 9, 2024 · 2 comments · May be fixed by #191
Open

Add movement to starting position in seq.scan() #190

BrianJKoopman opened this issue Dec 9, 2024 · 2 comments · May be fixed by #191
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@BrianJKoopman
Copy link
Member

Sometimes scans have accidentally been started in an incorrect location. Adding a starting position argument to seq.scan() and calling acu.move_to() within seq.scan() might mitigate the issue.

@BrianJKoopman BrianJKoopman added enhancement New feature or request good first issue Good for newcomers labels Dec 9, 2024
@newburgh
Copy link

I like this option; I definitely prefer to know the az/el the telescope is going to, which is solved if its an argument in the scan command. This requires a small modification to runlib and the scheduler?

BrianJKoopman added a commit that referenced this issue Dec 10, 2024
@BrianJKoopman BrianJKoopman linked a pull request Dec 10, 2024 that will close this issue
@BrianJKoopman
Copy link
Member Author

I like this option; I definitely prefer to know the az/el the telescope is going to, which is solved if its an argument in the scan command. This requires a small modification to runlib and the scheduler?

Yup, implemented in #191 as an optional argument to seq.scan(). The scheduler can then start to use this whenever convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants