You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The resolves and rejects assertions diverge from the naming convention use by Sinon assertions. In Sinon, resolves and rejects are used to program a stub or a fake, e.g. sinon.fake.resolves(42). The Sinon assertions to verify promises are sinon.assert.resolved(...) and sinon.assert.rejected(...).
I would therefore like to propose changing the names as follows:
resolves -> resolved
rejects -> rejected
toResolveWith -> toHaveBeenResolved
toRejectWith -> toHaveBeenRejected
The text was updated successfully, but these errors were encountered:
The
resolves
andrejects
assertions diverge from the naming convention use by Sinon assertions. In Sinon,resolves
andrejects
are used to program a stub or a fake, e.g.sinon.fake.resolves(42)
. The Sinon assertions to verify promises aresinon.assert.resolved(...)
andsinon.assert.rejected(...)
.I would therefore like to propose changing the names as follows:
resolves
->resolved
rejects
->rejected
toResolveWith
->toHaveBeenResolved
toRejectWith
->toHaveBeenRejected
The text was updated successfully, but these errors were encountered: