-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video/Visual Metrics on Safari iOS do not work #1598
Comments
Hey @soulgalore I was checking out the quick time video hack project. It seems to run on go. How do you plan to run the dependency for non docker builds? Will it be like a pre requisite for this particular flag? |
It will only work on Mac OS (since webdriver only work there). The dependencies will be installed by brew and the QuickTime hack will be a binary. |
The problem here is that all available recordings collide with Selenium. For example if we use https://github.com/facebook/idb we can start the video, run our test, stop the video but at that moment we also loose the Selenium session. A temporary fix for that would be to stop the video after the Selenium session ends on iOS, but that would make our code more complicated. |
@soulgalore Do we have any updates or if this issue might be fixed in the near future? Is this issue on the Apple driver side or sitespeed.io side? |
I've implemented it blindly, and now when the workaround for Safaridriver fixed the driver problem, video do not work. There's some more info in danielpaulus/quicktime_video_hack#96.
The text was updated successfully, but these errors were encountered: