Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add a flag opposite to userTimingWhitelist to specify what to block. #4344

Open
Amerousful opened this issue Dec 20, 2024 · 2 comments
Open

[Feature] Add a flag opposite to userTimingWhitelist to specify what to block. #4344

Amerousful opened this issue Dec 20, 2024 · 2 comments

Comments

@Amerousful
Copy link
Contributor

Amerousful commented Dec 20, 2024 •
edited
Loading

Feature/improvement

Original flag for idea: --userTimingWhitelist

It looks more convenient to block some special metrics from Google, Facebook, and so on. The weak point of whitelist that we can easily miss a new or unexpected metrics.
@soulgalore
Copy link
Member

Thank you @Amerousful I'll add that. I've seen that I missed renaming that feature in sitespeed.io too, the correct name is userTimingAllowList.

soulgalore added a commit to sitespeedio/browsertime that referenced this issue Dec 22, 2024
@soulgalore
Add --userTimingBlockList sitespeedio/sitespeed.io#4344
7b1473e
soulgalore added a commit to sitespeedio/browsertime that referenced this issue Dec 22, 2024
@soulgalore
Add --userTimingBlockList sitespeedio/sitespeed.io#4344 (#2227)
5b140c4
@Amerousful
Copy link
Contributor Author

You're welcome!
Yeap, this's a good point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soulgalore @Amerousful