Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Changes Setting #7

Open
jayfunk opened this issue Aug 17, 2016 · 1 comment
Open

Preview Changes Setting #7

jayfunk opened this issue Aug 17, 2016 · 1 comment

Comments

@jayfunk
Copy link
Collaborator

jayfunk commented Aug 17, 2016

Have default setting that will preview the changes before committing them. This view should be similar to the find all buffer and being able to navigate those changes with clicks or keyboard shortcuts. Saving that buffer will close it and commit the changes. Closing the buffer without a save will abort the operation

@jurassix
Copy link
Member

This feature requires changes to jscodeshift around their reporting. I've opened an issue, FB was unresponsive until I closed it. They may be interested in a PR once I fork and do the work. I've found the extension points I need inside jscodeshift, seems pretty straightforward.

Remaining pieces are what is the contract to return? At the basic level we need which files would be change. Next it would be great to just return new source and we can do a diff on our end. Or possibly figure out some way of just sending the lines that changed. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants