-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove git dependency? #354
Comments
The content inside your ERB tag looks generally ok (though you might want to deploy:
git_sha: <%= ... %> You can also set SKYLIGHT_DEPLOY_GIT_SHA in your env. The stderr redirection already allows for |
Good point. Thanks. I'm actually setting it here now. Our security setup (very open source - no closed repos) means that we don't use environment variables and instead have everything powered internally by AWS's Secrets Manager, which is why this is a bit of a round-about way to do it in the Environment.rb file.
If the Looking in the But it's your app! 🙂 |
Valid point. We'll put it on the roadmap. |
This line requires the git executable to be installed. Our Dockerfiles are optimised to not have unnecessary things such as
git
installed, which means although the.git
directory is there, this workflow fails for us.Rather than relying on a binary, it might be a nicer option to read directly from the files that
git
itself reads from, which (I haven't checked, but I presume) are.git/HEAD
and then whatever that points to (e.g..git/refs/heads/main
for our deployed app).Here's an example of the config I'm trying out at Exercism for this: https://github.com/exercism/website/pull/1069/files
If we changed this upstream in this repo I could remove that messiness :)
The text was updated successfully, but these errors were encountered: