-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeviceTimeoutError #6
Comments
Thinking about this, |
Previously get_device or the related functions would retrieve a list of devices that it contacted in the last x seconds. Then we would contact each light in turn to try and apply some sort of filtering. This would error out if the light had been switched off. This patch attempts to contact each light and skips it if it cannot be contacted. Closes smarthall#6
Still seems to be a problem in that if DeviceTimeoutError occurs in some situations it will forget about that light even if it is turned back on again. Still investigating. |
Think we really should cache the label so we don't have to do a network access every time |
Previously get_device or the related functions would retrieve a list of devices that it contacted in the last x seconds. Then we would contact each light in turn to try and apply some sort of filtering. This would error out if the light had been switched off. This patch attempts to contact each light and skips it if it cannot be contacted. This also caches the label of the light so we can display the repr string even if the light is offline. Closes smarthall#6
I too have run into this. The code should really keep going instead of crashing like this. I shouldn't have to restart the script because of a momentary IP glitch. |
Seems that the library somehow gets into a weird state where it won't talk anymore to the light, and has to be restarted for it to work again.
I believe the light in question is online and fully operational. Yes I know, the stack trace would imply otherwise.
The text was updated successfully, but these errors were encountered: