Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depends on old bitstruct #9

Open
brianmay opened this issue Mar 24, 2016 · 3 comments
Open

depends on old bitstruct #9

brianmay opened this issue Mar 24, 2016 · 3 comments

Comments

@brianmay
Copy link

Hello,

Not sure if we actually need to depend on bitstruct, however I think Python has similar functionality built in and already packaged in Debian.

e.g. https://docs.python.org/2/library/struct.html

In addition bitstruct appears to be buggy and perhaps not really well maintained. eerimoq/bitstruct#5

Regards

@eerimoq
Copy link

eerimoq commented Mar 24, 2016

It is well maintained! =)

Hopefully you are satisfied with the new manifest and the explanation of why the testcase failed.

If you want to use the latest version of bitstruct instead of 1.0.0, please note that version 2.0.0 has non-backwards compatible changes. The format specifier b was renamed to r, and ? was renamed to b. r for raw, and b for boolean.

Erik

@brianmay
Copy link
Author

Just attempting to create a proper Debian package for the latest bitstruct. So I can create a package for lifx-sdk.

bitstruct might be well maintained, not so sure about this project :-(. @smarthall Are you still interested in maintaining this project? If not would you be willing to give me write access to the github respository, the pypi repository, and readthedocs (if applicable) so I can fix some of these problems?

Will keep this bug report as a reminder to check for compatibility. I see I was using bitstruct version 1.0.0, so this might actually be an issue.

@brianmay
Copy link
Author

I see some b format specifiers in lifx/protocol.py - I guess these need to be changed to r. I don't see any ? format specifiers.

@brianmay brianmay changed the title depends on bitstruct depends on old bitstruct Mar 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants