Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates are not semver compatible #582

Open
FrTerstappen opened this issue Dec 4, 2024 · 0 comments
Open

Updates are not semver compatible #582

FrTerstappen opened this issue Dec 4, 2024 · 0 comments

Comments

@FrTerstappen
Copy link
Contributor

Hello,

I just updated zitadel-rust in one of my projects from v5.3.1 to v5.3.2. This lead to my code not compiling because the struct AddOidcAppRequest now has the field back_channel_logout_uri.

I think this was added in zitadel with version 2.65.0 https://github.com/zitadel/zitadel/releases/tag/v2.65.0

My guess is that the generated code was generated for the new version of zitadel and the changelog and version increment is just for the human made changes in this project.

I propose yanking v5.3.2 and making a new release with a semver compatible version number.

I think this project could benefit from being split into two crates with one being only the generated code and the other being a wrapper for it. This is in line with how many of the FFI-crates work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant