Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customizing retry options for waiters #839

Closed
1 task
aajtodd opened this issue Apr 21, 2023 · 1 comment · Fixed by #1183
Closed
1 task

Allow customizing retry options for waiters #839

aajtodd opened this issue Apr 21, 2023 · 1 comment · Fixed by #1183
Labels
enhancement New feature or request no-auto-closure We do not want this issue to be automatically closed.

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Apr 21, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue, please leave a comment

Describe the Feature

Waiters are generated as wait<Action>(input: <InputType>): Outcome<OutputType>. Internally the retry strategy token bucket, max attempts, and other options are hard coded (some come from the waiters spec). It would be useful to allow customizing/overriding some of the retry parameters (e.g. set higher or lower max attempts, delay parameters, etc).

Is your Feature Request related to a problem?

Proposed Solution

Describe alternatives you've considered

Additional Context

  • I may be able to implement this feature request
@aajtodd aajtodd added the enhancement New feature or request label Apr 21, 2023
@ianbotsf ianbotsf mentioned this issue Apr 21, 2023
Closed
@ianbotsf ianbotsf added the no-auto-closure We do not want this issue to be automatically closed. label Apr 8, 2024
@lauzadis lauzadis mentioned this issue Nov 20, 2024
Merged
@ianbotsf
Copy link
Contributor

ianbotsf commented Dec 9, 2024

Implemented by @lauzadis in #1183. Resolving as fixed.

@ianbotsf ianbotsf closed this as completed Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request no-auto-closure We do not want this issue to be automatically closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add retryStrategy configuration option for waiters smithy-lang/smithy-kotlin
2 participants
@aajtodd @ianbotsf