Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Compliance Tests #157

Open
rcoh opened this issue Jan 15, 2021 · 3 comments
Open

S3 Compliance Tests #157

rcoh opened this issue Jan 15, 2021 · 3 comments
Labels
good first issue Good for newcomers large sdk testing tracking Meta-issues to track overall progress
Milestone

Comments

@rcoh
Copy link
Collaborator

rcoh commented Jan 15, 2021

Botocore defines a large suite of compliance testing for S3—we should extract these as best we can into protocol tests:
https://github.com/boto/botocore/blob/develop/tests/functional/test_s3.py

@rcoh rcoh added tracking Meta-issues to track overall progress large design testing labels Jan 15, 2021
@rcoh rcoh added this to the S3 milestone Feb 16, 2021
@rcoh rcoh modified the milestones: S3, GA Dec 13, 2021
@Velfi Velfi added good first issue Good for newcomers and removed design labels Sep 26, 2022
@jdisanti jdisanti removed the sdk-ga label Apr 4, 2024
@aajtodd
Copy link
Contributor

aajtodd commented Jun 5, 2024

There are S3 specific protocol tests that we can/should use in-favor of hand written ones: https://github.com/smithy-lang/smithy/blob/main/smithy-aws-protocol-tests/model/restXml/services/s3.smithy

@aajtodd
Copy link
Contributor

aajtodd commented Jun 5, 2024

NOTE: These are difficult to consume currently in sdk-adhoc-test project as s3 pulls in aws-config as a dev dependency. This creates conflicts between relocated and non-relocated runtime crates since that project doesn't do any of the work that the actual aws/sdk project does.

@rcoh
Copy link
Collaborator Author

rcoh commented Jun 5, 2024

You could consider consuming them but transforming them to be apply tests that apply to the S3 model so that you can use them during actual codegen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers large sdk testing tracking Meta-issues to track overall progress
Projects
None yet
Development

No branches or pull requests

4 participants