Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement event streaming initial messages in AwsJson #2237

Closed
82marbag opened this issue Jan 20, 2023 · 2 comments
Closed

Implement event streaming initial messages in AwsJson #2237

82marbag opened this issue Jan 20, 2023 · 2 comments
Labels
event-stream

Comments

@82marbag
Copy link
Contributor

82marbag commented Jan 20, 2023 •
edited
Loading

#2230 throws an exception if a non-streaming member and a streaming-member are in the payload of an AwsJson 1.0 request/response.

smithy-lang/smithy#1584 confirmed this constraint is not required and we should relax it. Note that this is backwards compatible.
@david-perez
Copy link
Contributor

Relevant code:

https://github.com/awslabs/smithy-rs/blob/c901c0b1c69ddbae350529c0f8116c4ab06fd348/codegen-core/src/main/kotlin/software/amazon/smithy/rust/codegen/core/smithy/protocols/AwsJson.kt#L51-L59

In other words, this issue is saying we haven't implemented initial messages in the awsJson1.x protocols.

@david-perez david-perez changed the title Don't require unique members with streaming in AwsJson Implement event streaming initial messages in AwsJson Apr 4, 2023
@jdisanti
Copy link
Collaborator

jdisanti commented Apr 5, 2024

Duplicate of #121

@jdisanti jdisanti marked this as a duplicate of #121 Apr 5, 2024
@jdisanti jdisanti closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
event-stream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdisanti @david-perez @82marbag