Compile error when using enum as query parameter

[MikailBag]

Consider the following code:

$version: "1.0"

namespace aws.protocoltests.tmp

use aws.protocols#restJson1

@restJson1
service Tmp {
    version: "1.0.0",
    resources: [Probe],
}

@enum([
    {
        value: "ALIVE"
    },
    {
        value: "READY"
    }
])
string Kind


structure GetProbeInput {
    @httpLabel
    @required
    kind: Kind
}

@readonly
@http(method: "GET", uri: "/health/{kind}")
operation GetProbe {
    input: GetProbeInput,
}

resource Probe {
    read: GetProbe,
}

Given such a model, smithy-rs from HEAD produces invalid client code. Build fails with an error:

error[E0277]: the trait bound `Kind: AsRef<str>` is not satisfied
  --> enum-in-query-params/rust-codegen/src/input.rs:57:51
   |
57 |         let kind = smithy_http::label::fmt_string(input_1, false);
   |                                                   ^^^^^^^ the trait `AsRef<str>` is not implemented for `Kind`
   | 
  ::: /home/mb/projects/smithy-rs/rust-runtime/smithy-http/src/label.rs:15:22
   |
15 | pub fn fmt_string<T: AsRef<str>>(t: T, greedy: bool) -> String {
   |                      ---------- required by this bound in `smithy_http::label::fmt_string`
   |
   = note: required because of the requirements on the impl of `AsRef<str>` for `&Kind`

error: aborting due to previous error

[MikailBag]

Turns out, AsRef impl is only generated if enum definitions have name property set. So the fix is to add "name" fields to all enums used in URLs.

[rcoh]

thanks for the report! you'll get a nicer client if you set a Name field so that's probably what you want to do anyway, but we'll get a fix for this out as well.