Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helpful lint warnings to all crates #763

Closed
12 of 21 tasks
Velfi opened this issue Oct 11, 2021 · 0 comments
Closed
12 of 21 tasks

Add helpful lint warnings to all crates #763

Velfi opened this issue Oct 11, 2021 · 0 comments
Labels
client sdk-ga
Milestone
SDK GA

Comments

@Velfi
Copy link
Contributor

Velfi commented Oct 11, 2021 •
edited by rcoh
Loading

Our crates would benefit from more linting.

#![warn(
    missing_debug_implementations,
    missing_docs,
    rust_2018_idioms,
    rustdoc::missing_crate_level_docs,
    unreachable_pub
)]

related:

AWS runtime crates:

  • aws-config
  • aws-endpoint
  • aws-http
  • aws-hyper (deprecated)
  • aws-inlineable
  • aws-sig-auth
  • aws-sigv4
  • aws-types

Smithy runtime crates:

  • aws-smithy-async (partially done)
  • aws-smithy-checksums
  • aws-smithy-client (partially done)
  • aws-smithy-eventstream
  • aws-smithy-http
  • aws-smithy-http-tower
  • aws-smithy-json
  • aws-smithy-protocol-test
  • aws-smithy-query
  • aws-smithy-types
  • aws-smithy-types-convert
  • aws-smithy-xml
@Velfi Velfi changed the title Add #![warn(missing_docs)] to all crates Add helpful lint warnings to all crates Oct 11, 2021
@jdisanti jdisanti mentioned this issue May 28, 2022
Merged
2 tasks
@jdisanti jdisanti added this to the SDK GA milestone Sep 30, 2022
@jdisanti jdisanti mentioned this issue Oct 10, 2022
Closed
2 tasks
@rcoh rcoh closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
client sdk-ga
Projects
None yet
Milestone
SDK GA
Development

No branches or pull requests
3 participants
@jdisanti @rcoh @Velfi