Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json parser parses epoch seconds itself rather than using aws-smithy-types #841

Open
jdisanti opened this issue Nov 8, 2021 · 0 comments
Labels
bug Something isn't working low-priority

Comments

@jdisanti
Copy link
Collaborator

jdisanti commented Nov 8, 2021

The json parser currently does its own parsing for epoch seconds rather than using the code in smithy-types, and it is using a f64 to do this parsing, which can lead to loss of precision (whereas smithy-types does its own parsing into higher precision types without floating points).

The json parser should be refactored to keep a reference to the original number string as well as the parsed equivalent so that the generated token stream parsing logic can decide to parse the timestamp with the better method in smithy-types.

@jdisanti jdisanti added the bug Something isn't working label Nov 8, 2021
@jdisanti jdisanti changed the title Json parser parses epoch seconds timestamps itself rather than using smithy-types Json parser parses epoch seconds itself rather than using aws-smithy-types Nov 8, 2021
@Velfi Velfi added design and removed design labels Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-priority
Projects
None yet
Development

No branches or pull requests

2 participants