Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS should support multiple origins #1396

Open
Baccata opened this issue Sep 10, 2022 · 0 comments
Open

CORS should support multiple origins #1396

Baccata opened this issue Sep 10, 2022 · 0 comments
Labels
feature-request A feature should be added or improved.

Comments

@Baccata
Copy link

Baccata commented Sep 10, 2022

The current cors trait does not support providing a list of multiple allowed origins. See [https://github.com/awslabs/smithy/blob/main/smithy-model/src/main/java/software/amazon/smithy/model/traits/CorsTrait.java#L37].

This is limiting the implementation of Smithy-driven CORS-related middleware to a strict subset of what should be possible.

A change could probably be made in a backward compatible manner by deprecating the origin field of the trait in favour of an origins field that'd take a list of origins.

@jvschneid jvschneid added the feature-request A feature should be added or improved. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants