Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidationException protocol tests for restXml #1446

Open
david-perez opened this issue Oct 11, 2022 · 0 comments
Open

ValidationException protocol tests for restXml #1446

david-perez opened this issue Oct 11, 2022 · 0 comments
Labels
protocol-test New protocol tests are needed server This issue involves the specification for server software.

Comments

@david-perez
Copy link
Contributor

This repository contains a test suite for the restJson1 protocol with httpMalformedRequestTests that need to be rejected because the request input does not adhere to the modeled constraints. The test suite is under smithy-aws-protocol-tests/model/restJson1/validation.

This test suite has proved to be very helfpul for the implementation of constraint traits in smithy-rs and for me to not deviate in the error message contents from the already existing implementation in smithy-typescript. I presume that the test suite is also normative for the awsJson 1.0 and awsJson 1.1 protocols, since all these protocols share JSON as their serialization format (but it'd be good to explicitly call this fact out in the spec or add protocol tests if there are deviations).

However, there is no reference for the restXml protocol. This issue is a feature request for such test suite to be added.

@srchase srchase added the protocol-test New protocol tests are needed label Dec 30, 2022
@kstich kstich added the server This issue involves the specification for server software. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol-test New protocol tests are needed server This issue involves the specification for server software.
Projects
None yet
Development

No branches or pull requests

3 participants