Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol test enhancement] AWS JSON 1.1/1.0 are missing tests for requestId ser/deser #658

Open
rcoh opened this issue Dec 7, 2020 · 2 comments
Labels
protocol-test New protocol tests are needed

Comments

@rcoh
Copy link
Contributor

rcoh commented Dec 7, 2020

This is an especially important feature to test because unlike all other AWS 1.0/1.1 fields, requestId lives in the header:

HTTP/1.1 400 Bad Request
x-amzn-RequestId: LDM6CJP8RMQ1FHKSC1RBVJFPNVV4KQNSO5AEMF66Q9ASUAAJG
Content-Type: application/x-amz-json-1.0
Content-Length: 240
Date: Thu, 15 Mar 2012 23:56:23 GMT

{"__type":"com.amazonaws.dynamodb.v20120810#ResourceNotFoundException",
"message":"Requested resource not found: Table: tablename not found"}
@rcoh rcoh changed the title AWS JSON 1.1/1.0 Don't test requestId serialization [Protocol test enhancement] AWS JSON 1.1/1.0 Don't test requestId serialization Dec 7, 2020
@rcoh rcoh changed the title [Protocol test enhancement] AWS JSON 1.1/1.0 Don't test requestId serialization [Protocol test enhancement] AWS JSON 1.1/1.0 Don't test requestId ser/deser Dec 7, 2020
@jasdel
Copy link
Contributor

jasdel commented Dec 7, 2020

Similar issue with Request ID in the response document for XML based protocols. Having protocol specific testing that makes it easier for generators to validate correct behavior deserializing the request ID parameter.

@rcoh
Copy link
Contributor Author

rcoh commented Dec 7, 2020

The tricky part of this is that since requestId is unmodeled by smithy, some design work would actually be required to understand how to fit it into the protocol test machinery

@rcoh rcoh changed the title [Protocol test enhancement] AWS JSON 1.1/1.0 Don't test requestId ser/deser [Protocol test enhancement] AWS JSON 1.1/1.0 are missing tests for requestId ser/deser Jan 13, 2021
@mtdowling mtdowling added the protocol-test New protocol tests are needed label May 3, 2021
@github-actions github-actions bot added the closing-soon This issue will automatically close in 7 days unless further comments are made. label Aug 19, 2023
@jvschneid jvschneid removed the closing-soon This issue will automatically close in 7 days unless further comments are made. label Aug 21, 2023
@smithy-lang smithy-lang deleted a comment from github-actions bot Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol-test New protocol tests are needed
Projects
None yet
Development

No branches or pull requests

4 participants