Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate attachment files in zip file #22

Open
fireattack opened this issue Sep 14, 2024 · 4 comments
Open

Duplicate attachment files in zip file #22

fireattack opened this issue Sep 14, 2024 · 4 comments

Comments

@fireattack
Copy link

When downloading a post with file attachment e.g.

image

The downloaded zip file will have two copies of this file:

image

This only starts to happen lately.

@TaylorN15
Copy link

Just to add to this, it seems there are two links appearing within the Patreon post; I assume this is why the downloader is downloading them twice.

File Name: FileName1.txt
URL: https://www.patreon.com/file?h=123456789&i=1111111
File Name: FileName1.txt
URL: https://c10.patreonusercontent.com/4/patreon-media…sh=XXXXXX

@sneat
Copy link
Owner

sneat commented Oct 18, 2024

That makes sense as to why there are to. What would the expected outcome be from your perspectives?

@fireattack
Copy link
Author

fireattack commented Oct 18, 2024

Can we de-duplicate them before downloading? I think the first link would eventually redirect to the second; and even if not, it should be possible to tell by content-length and/or attachment filename.

@TaylorN15
Copy link

That makes sense as to why there are to. What would the expected outcome be from your perspectives?

Expected outcome would be for there to be no duplicate files...

I don't know if they can be de-duplicated before downloading as you'd have to read the file/stream to get the content length, and by that point it's already downloaded. I've just noticed that this is no longer happening for me anyway, so perhaps Patreon changed something?

Also, as a suggestion, rather than having a button for "Download xx files", maybe a checklist so that if this were to happen again, we can select which files we want to download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants