Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints in functions controlling DDS and DAC #147

Open
BECATRUE opened this issue Apr 18, 2024 · 1 comment
Open

Add type hints in functions controlling DDS and DAC #147

BECATRUE opened this issue Apr 18, 2024 · 1 comment
Labels
style Code format or conventions

Comments

@BECATRUE
Copy link
Member

Feature you want to implement

There is no type hints for return value in functions controlling DDS or DAC, e.g., set_dac_voltage().
Like other functions, we need to indicate their type infos.
@BECATRUE BECATRUE added the style Code format or conventions label Apr 18, 2024
@kangz12345
Copy link
Member

Oh nice observation, also we need to return None instead of return if the function returns any other values besides None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
style Code format or conventions
Projects
Device Monitors
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kangz12345 @BECATRUE