Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for updating channel setting #5

Open
BECATRUE opened this issue Nov 8, 2024 · 2 comments · May be fixed by #24
Open

Request for updating channel setting #5

BECATRUE opened this issue Nov 8, 2024 · 2 comments · May be fixed by #24
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@BECATRUE
Copy link
Member

BECATRUE commented Nov 8, 2024

Feature you want to implement

It is one of the core features to start or stop the measurement, set the exposure time, and set the measurement period of each channel.

For this, I will implement the channel viewer, which is consisting of entries (viewers) to set the exposure time and the measurement period, lock handler, and measurement plot.
(The PID controller might be added to here, but it's a long way off😂)

In addition, the corresponding slices would be added to handle the exposure time and the measurement period, and to set them.

How the feature is implemented

UI

The container for channel viewers would be implemented as a Flexbox with section component.
Accordingly, the channel viewer will be made as an article component.

Slice

The exposure and period would be added to ChannelInfo in the channel slice.
Also, the corresponding asynchronous thunks will be implemented to request for updating them.

References

@BECATRUE BECATRUE added the enhancement New feature or request label Nov 8, 2024
@BECATRUE BECATRUE added this to the v1.0.0 (Tentative title) milestone Nov 12, 2024
@BECATRUE BECATRUE assigned BECATRUE and unassigned BECATRUE Nov 18, 2024
@kangz12345 kangz12345 self-assigned this Nov 21, 2024
@kangz12345
Copy link
Member

I will use Flexbox for the component. Also, I will get rid of the table that I added in #20, as the flexbox will play its role instead.

@BECATRUE BECATRUE self-assigned this Nov 26, 2024
@kangz12345
Copy link
Member

I pushed my work on kangz12345/5/request-for-updating-channel-setting.

BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
I used `scss` instead of `css`, which is the advanced version of `css`.

See also: #5
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
BECATRUE added a commit that referenced this issue Nov 27, 2024
@BECATRUE BECATRUE linked a pull request Nov 27, 2024 that will close this issue
BECATRUE added a commit that referenced this issue Nov 28, 2024
BECATRUE added a commit that referenced this issue Dec 3, 2024
BECATRUE added a commit that referenced this issue Dec 3, 2024
See also: #5
BECATRUE added a commit that referenced this issue Dec 19, 2024
See also: #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants