[arista][feature] Add yang model for DEBUG_DROP_MONITOR table #21694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add yang model definition - Add testcases covering new yang model - Update documentation to describe the new table
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arista-hpandya
changed the title
| description "Stores configuration for debug drop monitor in CONFIG_DB"; | ||
|
|
||
| leaf status { | ||
| type string { |
There was a problem hiding this comment.
Please consider using sonic-types
|
|
||
| leaf window { | ||
| type uint64; | ||
| default 900; |
|
|
||
| leaf incident_count_threshold { | ||
| type uint64; | ||
| default 3; |
|
|
||
| leaf drop_count_threshold { | ||
| type uint64; | ||
| default 100; |
wen587
reviewed
Feb 11, 2025
| @@ -0,0 +1,51 @@ | |||
| module sonic-configurable-drop-monitor { | |||
There was a problem hiding this comment.
What's the reason to choose sonic-configurable-drop-monitor instead of sonic-debug-drop-monitor?
wen587
reviewed
Feb 11, 2025
| } | ||
|
|
||
| container sonic-configurable-drop-monitor { | ||
| container DEBUG_DROP_MONITOR { |
There was a problem hiding this comment.
Hi @theasianpianist , please check if DEBUG_COUNTER and DEBUG_COUNTER_DROP_REASONhas dependency on this for github issue missing YANG: #21505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the YANG model definition for the
DEBUG_DROP_MONITORtable to the SONiC yang models repository. The new YANG model defines the schema for configuring and monitoring persistent drop counters in SONiC.Changes:
sonic-debug-drop-monitor.yangtosonic-yang-models/yang/.tests/to cover the new YANG model, including validation of configuration data and schema.docs/to describe the newDEBUG_DROP_MONITORtable and its attributes.Why I did it
To provide a standardized and programmatic way to configure and monitor persistent drop counters in SONiC. This enhances the manageability and observability of network traffic.
Work item tracking - Microsoft ADO (number only):
Fixes #21675
HLD: sonic-net/SONiC#1912
How I did it
Created a new YANG model file, implemented test cases for validation, and updated the relevant documentation.
How to verify it
sonic-debug-drop-monitor.yangfile in thesonic-yang-models/yang/directory.tests/and ensure they pass.docs/for accuracy and completeness.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Added YANG model definition for the DEBUG_DROP_MONITOR table, enabling standardized configuration and monitoring of persistent drop counters.
Link to config_db schema for YANG module changes
https://github.com/sonic-net/sonic-buildimage/pull/21694/files#diff-7202f7348dad4b5be36f441f7ff0a5d6468395cbf89a9b75aa87399cef07292d
A picture of a cute animal (not mandatory but encouraged)