Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseRobyn file_path and other parameters #1108

Open
dave42w opened this issue Jan 10, 2025 · 2 comments
Open

BaseRobyn file_path and other parameters #1108

dave42w opened this issue Jan 10, 2025 · 2 comments

Comments

@dave42w
Copy link
Contributor

dave42w commented Jan 10, 2025

          we probably also don't need a file_path in the subrouters now, right?

Originally posted by @sansyrox in #1100 (comment)

Agreed.

It seems to me that the SubRouter should not hold any of the general configuration (config object, filepath etc). Instead it needs to know the BaseRobyn that it belongs to (to get the config etc from). So include_router should set a ParentBaseRobyn property in the SubRouter that is being included.

@sansyrox
Copy link
Member

Yep, agreed. This will also likely be a breaking change.

@dave42w
Copy link
Contributor Author

dave42w commented Jan 11, 2025

Yep, agreed. This will also likely be a breaking change.

Hopefully, we can keep that to a minimum at least for the documented ways of using Robyn.

I'll do it in small careful steps as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants