fix: (and improve) YouTube component behavior with playlist #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix the src construction for playlists - update unit tests
0gust1
changed the title
0gust1
changed the title
|
Friendly ping on this PR (sorry for the noise). I'm currently working on a static website that would make use of embedded YT playlists and I really don't want to reinvent the wheel (hence this annoying message :) ). I also noticed some breakages in CI jobs, feel free to tell if you need an hand here or here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #775
Playlists with listId weren't functionning.
indexprop (which playlist item to start)