Replies: 6 comments 3 replies
-
🤔 I think I might prefer to keep the name short. I understand that My other actions all have the |
Beta Was this translation helpful? Give feedback.
-
Yeah this is the biggest thing in my book. Verbs are awesome to get a quick idea of what something does. I remember that it was a literal rule in some of my compsci classes that all functions have verbs in their names. It's actually a good convention. https://stackoverflow.com/a/1991341
I can understand this. That's why I renamed my action first from jcbhmr/publish-to-github-wiki to jcbhmr/publish-wiki but that didn't have "action" in it, so I added the suffix to seem like a vaguely english title. I guess. That worked for me. I accept that you have different preferences.
Understandable. I accept that, but I don't think history should necessitate or require that such a trend continue ad infinitum. break the mold lmao. I guess if you find my argument persuasive enough, there's never a better time than now to make change. But I understand that as-is is way easier and "safer". So yeah. I'll close this but I guess at least I proposed the idea. Thanks for explaining your rationale! 👍 ❤ btw no hard feelings 🤣 |
Beta Was this translation helpful? Give feedback.
-
As further evidence for the -action suffix vs actions- prefix, I present statistical popularity of the naming conventions: https://sourcegraph.com/search?q=context:global+repo:actions-+count:all&patternType=standard&sm=1&groupBy=repo https://sourcegraph.com/search?q=context:global+repo:-action+count:all&patternType=standard&sm=0&groupBy=repo I'm sorry I'm so stuck on this but it's festering in my ocd brain. 🤣 |
Beta Was this translation helpful? Give feedback.
-
Also this would greatly help Google SEO indexing because right now it's using the literal repo slug as the title. Hence, a more descriptive, even if it's longer title would be a good idea.
I don't think this should be a problem. Look at how successful Andrew-Chen-Wang/github-wiki-action is! It's like 10 more chars vs the current name. Also how many times are you typing this name? Once. That's it. In one workflow file, and then never again probably. It's not like a I think this SEO thing is a compelling enough reason to pursue a rename. Now's the perfect time to do it while it's 🆕 opinion Also if I didn't comment on it before: the -action suffix is more "English-y". |
Beta Was this translation helpful? Give feedback.
-
I guess I can live with the |
Beta Was this translation helpful? Give feedback.
-
waitaminute what if you did
this would get the gh alias redirect thing where I could use spenserblack/publish-wiki-action or whatever and it would work! just an idea tho 🤷♀️ |
Beta Was this translation helpful? Give feedback.
-
I think this is a relatively cosmetic-level change. There's 301 redirects, so nothing would change for folks still using spenserblack/actions-wiki
This is largely motivated by branding, and SEO and all those good advertising things. And just good naming conventions in general. To quote myself
https://github.com/jcbhmr/publish-wiki-action-OLD/issues/12
This is an opinionated suggestion that you can close and I'll accept that. This is just a suggestion of my own thoughts on the naming stuff.
Beta Was this translation helpful? Give feedback.
All reactions