Weirdness for pytest

[Lewiscowles1986]

Describe the bug
unable to get config from context (I know it's covered elsewhere, but the reproduction does not seem to be the same.

Expected behavior
when I run pytest --cov -vvv ., I expect not to see errors from the env.py of alembic.

To Reproduce

python3 -m virtualenv .venv
. .venv/bin/activate
pip install alembic
pip install sqlalchemy
pip install pytest
pip install pytest-cov

alembic init --package migrations
mkdir -p projects/sample-project/{tests,sample_project}
touch projects/sample-project/sample_project/__init__.py
touch projects/sample-project/tests/test_sample.py

Put any test within test_sample.py

python -m pytest --cov -vvv .

Alembic complains that migrations/env.py references a config which cannot be loaded. 😭

Error

ERROR migrations/env.py - AttributeError: module 'alembic.context' has no attribute 'config'

Versions.

• OS: OSx
• Python: 3.11.4
• Alembic: 1.11.2
• SQLAlchemy: whatever the latest is (no main means I'm unsure how to check)
• Database: not setup yet
• DBAPI: not setup yet

Additional context
If I ignore the path to migrations, it works. Which is a fine work around; but seems a bit iffy longer-term.

Have a nice day!

[CaselIT]

Hi,

The issue is missing any kind of reproduction code. Can't really help without knowing what tou are doing

[Lewiscowles1986]

it gives exact instructions to reproduce. As mentioned the contents of the test are not important. Have you even tried running this?

[zzzeek]

the instructions don't reproduce anything. Here is my full console output:

$ python3 -m virtualenv .venv
. .venv/bin/activate
pip install alembic
pip install sqlalchemy
pip install pytest
pip install pytest-cov

alembic init --package migrations
mkdir -p projects/sample-project/{tests,sample_project}
touch projects/sample-project/sample_project/__init__.py
touch projects/sample-project/tests/test_sample.py
created virtual environment CPython3.11.4.final.0-64 in 418ms
  creator CPython3Posix(dest=/home/classic/tmp/foo/.venv, clear=False, no_vcs_ignore=False, global=False)
  seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=/home/classic/.local/share/virtualenv)
    added seed packages: pip==23.2.1, setuptools==68.0.0, wheel==0.40.0
  activators BashActivator,CShellActivator,FishActivator,NushellActivator,PowerShellActivator,PythonActivator
Collecting alembic
  Obtaining dependency information for alembic from https://files.pythonhosted.org/packages/ab/7d/b572fc6a51bc430b1fa0ef59591db32b14105093324d472eed8ea296d2df/alembic-1.11.3-py3-none-any.whl.metadata
  Downloading alembic-1.11.3-py3-none-any.whl.metadata (7.2 kB)
Collecting SQLAlchemy>=1.3.0 (from alembic)
  Obtaining dependency information for SQLAlchemy>=1.3.0 from https://files.pythonhosted.org/packages/dc/3e/d0c97146e4c707451c05b80ac712025d635b19aed1d867fed351de70c71c/SQLAlchemy-2.0.20-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached SQLAlchemy-2.0.20-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (9.4 kB)
Collecting Mako (from alembic)
  Using cached Mako-1.2.4-py3-none-any.whl (78 kB)
Collecting typing-extensions>=4 (from alembic)
  Obtaining dependency information for typing-extensions>=4 from https://files.pythonhosted.org/packages/ec/6b/63cc3df74987c36fe26157ee12e09e8f9db4de771e0f3404263117e75b95/typing_extensions-4.7.1-py3-none-any.whl.metadata
  Using cached typing_extensions-4.7.1-py3-none-any.whl.metadata (3.1 kB)
Collecting greenlet!=0.4.17 (from SQLAlchemy>=1.3.0->alembic)
  Using cached greenlet-2.0.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (618 kB)
Collecting MarkupSafe>=0.9.2 (from Mako->alembic)
  Obtaining dependency information for MarkupSafe>=0.9.2 from https://files.pythonhosted.org/packages/fe/21/2eff1de472ca6c99ec3993eab11308787b9879af9ca8bbceb4868cf4f2ca/MarkupSafe-2.1.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Using cached MarkupSafe-2.1.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (3.0 kB)
Downloading alembic-1.11.3-py3-none-any.whl (225 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 225.4/225.4 kB 4.1 MB/s eta 0:00:00
Using cached SQLAlchemy-2.0.20-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (3.2 MB)
Using cached typing_extensions-4.7.1-py3-none-any.whl (33 kB)
Using cached MarkupSafe-2.1.3-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (28 kB)
Installing collected packages: typing-extensions, MarkupSafe, greenlet, SQLAlchemy, Mako, alembic
Successfully installed Mako-1.2.4 MarkupSafe-2.1.3 SQLAlchemy-2.0.20 alembic-1.11.3 greenlet-2.0.2 typing-extensions-4.7.1
Requirement already satisfied: sqlalchemy in ./.venv/lib64/python3.11/site-packages (2.0.20)
Requirement already satisfied: typing-extensions>=4.2.0 in ./.venv/lib/python3.11/site-packages (from sqlalchemy) (4.7.1)
Requirement already satisfied: greenlet!=0.4.17 in ./.venv/lib64/python3.11/site-packages (from sqlalchemy) (2.0.2)
Collecting pytest
  Obtaining dependency information for pytest from https://files.pythonhosted.org/packages/33/b2/741130cbcf2bbfa852ed95a60dc311c9e232c7ed25bac3d9b8880a8df4ae/pytest-7.4.0-py3-none-any.whl.metadata
  Using cached pytest-7.4.0-py3-none-any.whl.metadata (8.0 kB)
Collecting iniconfig (from pytest)
  Using cached iniconfig-2.0.0-py3-none-any.whl (5.9 kB)
Collecting packaging (from pytest)
  Using cached packaging-23.1-py3-none-any.whl (48 kB)
Collecting pluggy<2.0,>=0.12 (from pytest)
  Obtaining dependency information for pluggy<2.0,>=0.12 from https://files.pythonhosted.org/packages/51/32/4a79112b8b87b21450b066e102d6608907f4c885ed7b04c3fdb085d4d6ae/pluggy-1.2.0-py3-none-any.whl.metadata
  Using cached pluggy-1.2.0-py3-none-any.whl.metadata (4.4 kB)
Using cached pytest-7.4.0-py3-none-any.whl (323 kB)
Using cached pluggy-1.2.0-py3-none-any.whl (17 kB)
Installing collected packages: pluggy, packaging, iniconfig, pytest
Successfully installed iniconfig-2.0.0 packaging-23.1 pluggy-1.2.0 pytest-7.4.0
Collecting pytest-cov
  Obtaining dependency information for pytest-cov from https://files.pythonhosted.org/packages/a7/4b/8b78d126e275efa2379b1c2e09dc52cf70df16fc3b90613ef82531499d73/pytest_cov-4.1.0-py3-none-any.whl.metadata
  Downloading pytest_cov-4.1.0-py3-none-any.whl.metadata (26 kB)
Requirement already satisfied: pytest>=4.6 in ./.venv/lib/python3.11/site-packages (from pytest-cov) (7.4.0)
Collecting coverage[toml]>=5.2.1 (from pytest-cov)
  Obtaining dependency information for coverage[toml]>=5.2.1 from https://files.pythonhosted.org/packages/55/63/f2dcc8f7f1587ae54bf8cc1c3b08e07e442633a953537dfaf658a0cbac2c/coverage-7.3.0-cp311-cp311-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata
  Downloading coverage-7.3.0-cp311-cp311-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (8.1 kB)
Requirement already satisfied: iniconfig in ./.venv/lib/python3.11/site-packages (from pytest>=4.6->pytest-cov) (2.0.0)
Requirement already satisfied: packaging in ./.venv/lib/python3.11/site-packages (from pytest>=4.6->pytest-cov) (23.1)
Requirement already satisfied: pluggy<2.0,>=0.12 in ./.venv/lib/python3.11/site-packages (from pytest>=4.6->pytest-cov) (1.2.0)
Downloading pytest_cov-4.1.0-py3-none-any.whl (21 kB)
Downloading coverage-7.3.0-cp311-cp311-manylinux_2_5_x86_64.manylinux1_x86_64.manylinux_2_17_x86_64.manylinux2014_x86_64.whl (232 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 232.9/232.9 kB 6.0 MB/s eta 0:00:00
Installing collected packages: coverage, pytest-cov
Successfully installed coverage-7.3.0 pytest-cov-4.1.0
  Creating directory '/home/classic/tmp/foo/migrations' ...  done
  Creating directory '/home/classic/tmp/foo/migrations/versions' ...  done
  Generating /home/classic/tmp/foo/migrations/README ...  done
  Generating /home/classic/tmp/foo/alembic.ini ...  done
  Generating /home/classic/tmp/foo/migrations/env.py ...  done
  Generating /home/classic/tmp/foo/migrations/script.py.mako ...  done
  Adding {path!r} ...  done
  Adding {path!r} ...  done
  Please edit configuration/connection/logging settings in '/home/classic/tmp/foo/alembic.ini' before proceeding.
(.venv) [classic@zotac foo]$ python -m pytest --cov -vvv .
=============================================================== test session starts ================================================================
platform linux -- Python 3.11.4, pytest-7.4.0, pluggy-1.2.0 -- /home/classic/tmp/foo/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/classic/tmp/foo
plugins: cov-4.1.0
collected 0 items                                                                                                                                  


---------- coverage: platform linux, python 3.11.4-final-0 -----------
Name                                           Stmts   Miss  Cover
------------------------------------------------------------------
projects/sample-project/tests/test_sample.py       0      0   100%
------------------------------------------------------------------
TOTAL                                              0      0   100%

============================================================== no tests ran in 0.05s ===============================================================

# NOTE: I put a test in test_sample
(.venv) [classic@zotac foo]$ vi projects/sample-project/tests/test_sample.py 

(.venv) [classic@zotac foo]$ python -m pytest --cov -vvv .
=============================================================== test session starts ================================================================
platform linux -- Python 3.11.4, pytest-7.4.0, pluggy-1.2.0 -- /home/classic/tmp/foo/.venv/bin/python
cachedir: .pytest_cache
rootdir: /home/classic/tmp/foo
plugins: cov-4.1.0
collected 1 item                                                                                                                                   

projects/sample-project/tests/test_sample.py::test_foo PASSED                                                                                [100%]

---------- coverage: platform linux, python 3.11.4-final-0 -----------
Name                                           Stmts   Miss  Cover
------------------------------------------------------------------
projects/sample-project/tests/test_sample.py       2      0   100%
------------------------------------------------------------------
TOTAL                                              2      0   100%


================================================================ 1 passed in 0.06s =================================================================
(.venv) [classic@zotac foo]$ 

[zzzeek]

usually a stack trace is very informative to share as that indicates what exactly is raising an error and how

[zzzeek]

hi -

why using the --package parameter? that's why it's creating a "package" which is then not importable. This parameter was contributed by users who for some reason really wanted their alembic/ directory to have an __init__.py file. however, this is not the original vision for what alembic/ is used for, and env.py was never intended to be importable outside of the alembic runtime.

[Lewiscowles1986]

this happens regardless of the --package argument

[zzzeek]

what is attempting to import env.py when there is no __init__.py present in its local directory?

[Lewiscowles1986]

pytest is I guess

[CaselIT]

Could you share an example of test file that presents the problem?

Without it there isn't much else to say other than "can't reproduce, sorry"

[Lewiscowles1986]

The test case I am using

def test_true_is_true():
    assert True is True

This is across two machines, but maybe it's a me problem 😓

[CaselIT]

Does that test import anything? Does the library package import something?
Start from an empty project, like the one tried by mike then add bits until it starts failing, so you can find what's causing the issue

[Lewiscowles1986]

The test is literally all the text I've shown; there are no hidden things; it's as I've specified, and for some reason my computer is failing to work. I'll do a reset; I've closed this as to be honest, I am becoming frustrated that nobody else can replicate, when I have two machines displaying this behaviour.

[zzzeek]

can you run alembic with the --raiseerr parameter and please show the complete stack trace printed?