Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOD proxying assumes only single login node #212

Open
sjpb opened this issue Sep 20, 2022 · 1 comment
Open

OOD proxying assumes only single login node #212

sjpb opened this issue Sep 20, 2022 · 1 comment

Comments

@sjpb
Copy link
Collaborator

sjpb commented Sep 20, 2022

OOD defaults are potentially broken for >1 login node.

  1. Everything layout defines openondemand as all login, so could have multiple openondemand nodes
environments/common/layouts/everything:
[openondemand:children]
# Host to run Open Ondemand server on - subset of login
login
  1. Clearly grafana can only proxy a single OOD node, so this proxy config assumes openondemand_servername is the same on all hosts:
environments/common/inventory/group_vars/all/grafana.yml:grafana_url_openondemand_proxy: "https://{{ openondemand_servername | default('') }}/node/{{ groups['grafana'].0 }}/{{ grafana_port }}"
  1. The arcus definition is actually ok for this:
environments/arcus/inventory/group_vars/all/openondemand.yml:openondemand_servername: "{{ hostvars[ groups['openondemand'] | first].ansible_host }}" # Use a SOCKS proxy to acccess

but this will be really easy to mess up

@sjpb
Copy link
Collaborator Author

sjpb commented Sep 20, 2022

Tried to fix this but you can't do:

grafana_url: "https://{{ hostvars[groups['openondemand'].0]['openondemand_servername'] }}..."

when openondemand_servername is also accessing hostvars - the "outer" use of it does not get a templated variables. Which kind-of makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant