From b46925f6dc9c99638661f69726a6ff9519a8d29e Mon Sep 17 00:00:00 2001 From: Yann Braga Date: Fri, 6 Dec 2024 14:06:27 +0100 Subject: [PATCH] Merge pull request #29832 from storybookjs/yann/disable-cra-sandboxes Build: Temporarily disable CRA sandboxes (cherry picked from commit ed4fb2da1b13070710db9940b8cd19c1bfd3255a) --- .circleci/config.yml | 36 +++++++++---------- .../cli-storybook/src/sandbox-templates.ts | 8 ++--- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4906899809e5..aee977a13fed 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -772,27 +772,27 @@ workflows: requires: - unit-tests - create-sandboxes: - parallelism: 14 + parallelism: 13 requires: - build - build-sandboxes: - parallelism: 14 + parallelism: 13 requires: - create-sandboxes - chromatic-sandboxes: - parallelism: 11 + parallelism: 10 requires: - build-sandboxes - e2e-production: - parallelism: 9 + parallelism: 8 requires: - build-sandboxes - e2e-dev: - parallelism: 2 + parallelism: 1 requires: - create-sandboxes - test-runner-production: - parallelism: 9 + parallelism: 8 requires: - build-sandboxes - vitest-integration: @@ -847,27 +847,27 @@ workflows: requires: - unit-tests - create-sandboxes: - parallelism: 20 + parallelism: 19 requires: - build - build-sandboxes: - parallelism: 20 + parallelism: 19 requires: - create-sandboxes - chromatic-sandboxes: - parallelism: 17 + parallelism: 16 requires: - build-sandboxes - e2e-production: - parallelism: 15 + parallelism: 14 requires: - build-sandboxes - e2e-dev: - parallelism: 2 + parallelism: 1 requires: - create-sandboxes - test-runner-production: - parallelism: 15 + parallelism: 14 requires: - build-sandboxes - vitest-integration: @@ -920,30 +920,30 @@ workflows: requires: - build - create-sandboxes: - parallelism: 37 + parallelism: 35 requires: - build # - smoke-test-sandboxes: # disabled for now # requires: # - create-sandboxes - build-sandboxes: - parallelism: 37 + parallelism: 35 requires: - create-sandboxes - chromatic-sandboxes: - parallelism: 34 + parallelism: 32 requires: - build-sandboxes - e2e-production: - parallelism: 32 + parallelism: 30 requires: - build-sandboxes - e2e-dev: - parallelism: 2 + parallelism: 1 requires: - create-sandboxes - test-runner-production: - parallelism: 32 + parallelism: 30 requires: - build-sandboxes - vitest-integration: diff --git a/code/lib/cli-storybook/src/sandbox-templates.ts b/code/lib/cli-storybook/src/sandbox-templates.ts index a43c3d83745e..4a5de11cb54c 100644 --- a/code/lib/cli-storybook/src/sandbox-templates.ts +++ b/code/lib/cli-storybook/src/sandbox-templates.ts @@ -172,7 +172,6 @@ const baseTemplates = { extraDependencies: ['server-only', 'prop-types'], }, skipTasks: ['e2e-tests-dev', 'bench', 'vitest-integration'], - inDevelopment: true, }, 'nextjs/default-ts': { name: 'Next.js Latest (Webpack | TypeScript)', @@ -229,7 +228,6 @@ const baseTemplates = { 'prop-types', ], }, - inDevelopment: true, skipTasks: ['e2e-tests-dev', 'bench'], }, 'experimental-nextjs-vite/default-ts': { @@ -769,7 +767,8 @@ export const allTemplates: Record = { }; export const normal: TemplateKey[] = [ - 'cra/default-ts', + // TODO: Add this back once we resolve the React 19 issues + // 'cra/default-ts', 'react-vite/default-ts', 'angular-cli/default-ts', 'vue3-vite/default-ts', @@ -799,7 +798,8 @@ export const merged: TemplateKey[] = [ export const daily: TemplateKey[] = [ ...merged, 'angular-cli/prerelease', - 'cra/default-js', + // TODO: Add this back once we resolve the React 19 issues + // 'cra/default-js', 'react-vite/default-js', 'react-vite/prerelease-ts', 'react-webpack/prerelease-ts',