Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W0101: Unreachable code on process_argus() #7

Open
verovaleros opened this issue Nov 18, 2022 · 0 comments
Open

W0101: Unreachable code on process_argus() #7

verovaleros opened this issue Nov 18, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@verovaleros
Copy link
Member

verovaleros commented Nov 18, 2022

The pylint tool threw this warning, indicating there is unreachable code in the netflow labeler:

netflowlabeler.py:957:8: W0101: Unreachable code (unreachable)

It seems there's a return instruction on the beginning of the function process_argus, which makes the rest of the code not to execute:

 947 def process_argus(column_idx, output_file, labelmachine, filetype):
 948     """
 949     DEPRECATED!! NEEDS UPDATE COMPLETELY
 950     Process an Argus file
 951     """
 952     try:
 953         print(column_idx)
 954         return 0
 955
 956         # This is argus files...
 957         amount_lines_processed = 0

While this function needs updating, I think it's good to remember this is there. Just in case.

@verovaleros verovaleros added the bug Something isn't working label Nov 18, 2022
@verovaleros verovaleros added this to the v0.6 milestone Nov 18, 2022
@verovaleros verovaleros moved this to 📋 Backlog in Netflow Labeler Nov 18, 2022
@verovaleros verovaleros removed this from the v0.6 milestone Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant