Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dep dependencies #112

Open
maxheld83 opened this issue Feb 15, 2021 · 0 comments
Open

remove dep dependencies #112

maxheld83 opened this issue Feb 15, 2021 · 0 comments

Comments

@maxheld83
Copy link
Contributor

maxheld83 commented Feb 15, 2021

we currently have a bunch of development dependencies:

metacheck/DESCRIPTION

Lines 78 to 83 in c01b21e

Remotes:
subugoe/[email protected],
subugoe/[email protected],
subugoe/rcrossref@51d036808c1dc1f46cf1bad1b136e97ad213e162,
rstudio/shinyvalidate@420aec079dbd2c0e12bf8350f4452d105a9cc45c,
subugoe/biblids@d44010e7d0b7d2eef016ef33a05d29e67417dfe6

These pose a risk to the stability/reproducibility of the app if their dependency graph includes dependencies that are not locked down to a git ref, as per https://github.com/subugoe/muggle/issues/184.
This has broken our builds sometimes in the past.

We should avoid by using CRAN versions in production as much as possible.
We can use our "own" dev versions (such as biblids), where we can, in turn, lock down dependencies hard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant