Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check shiny app runtime dependencies #115

Open
maxheld83 opened this issue Feb 16, 2021 · 3 comments
Open

check shiny app runtime dependencies #115

maxheld83 opened this issue Feb 16, 2021 · 3 comments
Labels
clean code
Milestone
Metacheck 2.0

Comments

@maxheld83
Copy link
Contributor

our CI currently has a whole: dependencies used in skeleton.Rmd aren't tested in check().

For example 3e0bf8f removed gluedown, though that was still needed.

Two ways to go about this:

  • run the shiny app in testing (runMetacheck() would have failed)
  • pass on dependencies to rmd in some programmatic way

Should probably do both.
maxheld83 added a commit that referenced this issue Feb 16, 2021
@maxheld83
add gluedown again opens #115
f91ad92
@maxheld83 maxheld83 added this to the Wide Release milestone Feb 16, 2021
njahn82 added a commit that referenced this issue Feb 16, 2021
@njahn82
not needed #115
b325841
@njahn82
Copy link
Collaborator

njahn82 commented Feb 16, 2021

Sorry, forgot to delete skeleton.Rmd, it is not needed

@njahn82
Copy link
Collaborator

njahn82 commented Feb 16, 2021

so, gluedown can be removed

@maxheld83
Copy link
Contributor Author

yes, thanks! That's already streamlined in #69.
This is more a note to self to test this at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clean code
Projects
None yet
Milestone
Metacheck 2.0
Development

No branches or pull requests
2 participants
@njahn82 @maxheld83