Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect against rcrossref timeout #166

Closed
maxheld83 opened this issue Mar 2, 2021 · 2 comments · Fixed by #168
Closed

protect against rcrossref timeout #166

maxheld83 opened this issue Mar 2, 2021 · 2 comments · Fixed by #168

Comments

@maxheld83
Copy link
Contributor

this happened:

2021-03-02T09:41:58.916873554Z Warning: Error in curl::curl_fetch_memory: Timeout was reached: [api.crossref.org] Operation timed out after 10002 milliseconds with 0 out of 0 bytes received
2021-03-02T09:41:58.977415402Z   4: <Anonymous>
2021-03-02T09:41:58.977464004Z   2: rmarkdown::run
2021-03-02T09:41:58.977471005Z   1: metacheck::runMetacheck
2021-03-02T09:51:47.918563748Z
2021-03-02T09:52:01.515461938Z
2021-03-02T09:52:01.525383406Z

It would be good to protect against this and/or retry, so that we don't get a catastrophic crash, or at least some good diagnostics.

@maxheld83 maxheld83 transferred this issue from maxheld83/biblids Mar 2, 2021
@maxheld83
Copy link
Contributor Author

purrr::insistently() might help ...

Though we then have to make sure that there is an overall timeout, because otherwise processes might live forever.

@maxheld83
Copy link
Contributor Author

may be related to not respecting the rate limit? #173

maxheld83 added a commit that referenced this issue Mar 4, 2021
@maxheld83 maxheld83 linked a pull request Mar 4, 2021 that will close this issue
maxheld83 added a commit that referenced this issue Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant