Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit DOI intake #19

Closed
maxheld83 opened this issue Nov 25, 2020 · 2 comments · Fixed by #168
Closed

limit DOI intake #19

maxheld83 opened this issue Nov 25, 2020 · 2 comments · Fixed by #168
Assignees

Comments

@maxheld83
Copy link
Contributor

No description provided.

@maxheld83
Copy link
Contributor Author

same as in #50 here, this is now (crudely) prevented in the shiny app, but we should test this downstream as well, ideally maybe using the same logic.

@maxheld83
Copy link
Contributor Author

@michaelavoigt just suggested this again as a feature.

Some background: The principle place for use to limit the number of DOIs is inside the report, where as part of the ingest status, users will be informed how many DOIs were dropped because they exceeded the limit (see #60, and more details in #124).

There are two reasons for this:

  1. We want to take on as few potentially invalid strings into the interactive R session as possible.
    For that reason, textInput currently only enforces a (generous) character limit, not a DOI limit.
    This is pretty cheap and may even be done in the client sometime soon (see https://github.com/subugoe/biblids/issues/40).
  2. Limiting the number of DOIs is actually a bit more subtle than at first expected, because we'd first want to filter out invalid and duplicate DOIs and then apply the limit.

But all that said we should still absolutely advertise right in the entry box what our limit is #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant