do not require biblids::is_doi_resolvable

[maxheld83]

@njahn82

Thanks. Do you have an example, how biblids::is_doi_found and biblids::is_doi_resolvable differ. They seem somehow redundant to me as DOIs must resolve to an URL. Maybe one function / api call testing if a DOI resolves is enough.

[maxheld83]

I read somewhere in the DOI spec that a DOI does not necessarily resolve to a URL, so it's possible to have a DOI known to DOI.org, but for the url fields to be empty.

But it's not really clear why we should care about that in the context of metacheck, one way or the other.

Even if a DOI had no URL, that shouldn't affect our downstream tests, nor necessarily be terribly relevant.

So I think you're right and I'm going to disable this asap.

[maxheld83]

As expected, didn't save much in the way of runtime.

bench::mark(metacheck = metacheck::render_email(sample(metacheck:::dois_many(), 10)))
#> Warning: Some expressions had a GC in every iteration; so filtering is disabled.
#> # A tibble: 1 x 6
#>   expression      min   median `itr/sec` mem_alloc `gc/sec`
#>   <bch:expr> <bch:tm> <bch:tm>     <dbl> <bch:byt>    <dbl>
#> 1 metacheck     25.1s    25.1s    0.0399    66.4MB    0.439

Actually, the whole thing now takes longer than in #133 but that must be random fluctuation.