Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test where runMetacheck is run inside of runtime container #54

Open
maxheld83 opened this issue Dec 10, 2020 · 0 comments
Open

add test where runMetacheck is run inside of runtime container #54

maxheld83 opened this issue Dec 10, 2020 · 0 comments
Labels
Milestone

Comments

@maxheld83
Copy link
Contributor

haha, this was a fun one just now solved in https://github.com/subugoe/metacheck/actions/runs/413556533.

There was apparently (?) a missing dependency, which never came up before because:

  • it was only needed when there were missing DOIs, which did not come up in much of the testing
  • the dependency (gluedown) is probably part of muggle-buildtime anyway (?), so it never came up inside ghactions testing
  • inside azure, muggle-runtime probably did not have this, and that's why it failed.

This is a pretty bad failure mode.
Fixes:

  • also run (smoke?) test on muggle-runtime in github actions (though even the entrypoint wouldn't have captured that?!)
  • don't use any dependencies in the rmarkdown template, because forgetting those doesn't get caught in R CMD check (as per refactor ELT + analysis codebase #52).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant