-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolate tests from live APIs #77
Comments
I thought and read a little bit about testing against (live) APIs, also including the recent ropensci book on the topic: https://books.ropensci.org/http-testing/ I think generally we should:
|
To test, if a compliance check works, we would record the HTTP calls and responses just once and re-use them, right? Like https://github.com/ropensci/vcr |
Mmh, I am not 💯sure yet, but I don't think we should be mocking anything in metacheck (as would be done via vcr). There's basically two sets of tests relevant here:
So in summary, I don't think there's any need for mocking in metacheck. This issue should still stay open until:
|
tests will currently ocassionally invalidate when cr data changes, and some of these changes percolate through.
that is causing noise.
The text was updated successfully, but these errors were encountered: