Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge files with secrets #28

Closed
maxheld83 opened this issue Sep 15, 2020 · 3 comments
Closed

purge files with secrets #28

maxheld83 opened this issue Sep 15, 2020 · 3 comments
Assignees

Comments

@maxheld83
Copy link
Contributor

same as #8

BFG: https://rtyley.github.io/bfg-repo-cleaner/

@Ahobert
Copy link
Collaborator

Ahobert commented Sep 15, 2020

I was not sure whether I will destroy something for your pull request, @maxheld83 so I did not delete anything for now.

Critical files are:

  • exclude_from_analysis.csv
  • exclude_from_inst_level_analysis.csv

We do not want to remove them entirely this time. They have two columns, one titled pk_kb_inst and a second one. We would want to remove the files from the repo, generate csv files that have just the second column and add them under the same name again in the data-raw folder.

@maxheld83 if you finish your pull request and still have some time and energy left, maybe you could take care of this? Otherwise, I will look into it tomorrow morning.

@maxheld83 maxheld83 self-assigned this Sep 15, 2020
@maxheld83
Copy link
Contributor Author

I think a simple way to go about this would be to add the remaining column as a simple R vector in, say exclude_from_analysis.R, and then to source() that file in place of the current readr::read_csv().
That way, we can cleanly kill all the old filenames, and also, one column doesn't really need a csv anyway.

But that will require some small changes in the remainder of the script, since the input is then a vector, and not a tibble.

@maxheld83 maxheld83 transferred this issue from subugoe/oauni_10_18 Oct 28, 2020
@maxheld83
Copy link
Contributor Author

closed in favor of #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants