-
Notifications
You must be signed in to change notification settings - Fork 462
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: mailboxer/mailboxer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: subvertical/mailboxer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
Can’t automatically merge.
Don’t worry, you can still create the pull request.
4
contributors
Commits on Jun 11, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 7350b8c - Browse repository at this point
Copy the full SHA 7350b8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39fc803 - Browse repository at this point
Copy the full SHA 39fc803View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6b7ee4 - Browse repository at this point
Copy the full SHA e6b7ee4View commit details
Commits on Dec 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 6aee285 - Browse repository at this point
Copy the full SHA 6aee285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67e09d0 - Browse repository at this point
Copy the full SHA 67e09d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5cb868 - Browse repository at this point
Copy the full SHA e5cb868View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f2b09f - Browse repository at this point
Copy the full SHA 6f2b09fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f43323 - Browse repository at this point
Copy the full SHA 2f43323View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a88aa3 - Browse repository at this point
Copy the full SHA 6a88aa3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72825a7 - Browse repository at this point
Copy the full SHA 72825a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6276ff - Browse repository at this point
Copy the full SHA d6276ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9744109 - Browse repository at this point
Copy the full SHA 9744109View commit details -
Do not use backticks for table names in between scope
This is a reimplementation of PR #406 by @jurgens that has been rebased with master and with a passing build. The use of backticks for table names is specific to the MySQL syntax. Other DBMSes like PostgreSQL use double quotes. However, all DBMSes should get along fine with only the table name in the query.
Configuration menu - View commit details
-
Copy full SHA for 337abf8 - Browse repository at this point
Copy the full SHA 337abf8View commit details -
Remove defunct Rails version checks
Since the gemspec has Rails 4.2 and later as a dependency, the old < 4 version checks for Rails should never be executed. This removes the now dead code.
Configuration menu - View commit details
-
Copy full SHA for 3c9b936 - Browse repository at this point
Copy the full SHA 3c9b936View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce88f3 - Browse repository at this point
Copy the full SHA 5ce88f3View commit details -
Don't hardcode model / table name unless necessary
Added a regression test because I was not sure removing the class name from the `belongs_to` would work. It does.
Configuration menu - View commit details
-
Copy full SHA for 3f263a2 - Browse repository at this point
Copy the full SHA 3f263a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebee6a6 - Browse repository at this point
Copy the full SHA ebee6a6View commit details -
The `autosave` flag in the notifications's `belongs_to` is currently necessary but removing it woudn't make the tests fail. This test catches it.
Configuration menu - View commit details
-
Copy full SHA for 6975cfd - Browse repository at this point
Copy the full SHA 6975cfdView commit details -
Since that commit, notifications no longer require a subject, so we'll never get duplicate validation errors and we don't need to clean those up.
Configuration menu - View commit details
-
Copy full SHA for 7d397d3 - Browse repository at this point
Copy the full SHA 7d397d3View commit details -
Save objects in a more straight way
It's simpler to just save the parent and let the children be autosaved (and autovalidated) since this is how Rails works out of the box. We just need to make sure the receipts are properly tied to the parent notification. We get that, again, by using Rails standard constructs like `association#build` instead of the ad-hoc `build_receipt` method. The previous behavior caused issues like getting duplicated errors in the notification object, because of the fact that everytime a receipt was saved, the parent notification would be saved too and validations would be (re)run.
Configuration menu - View commit details
-
Copy full SHA for 4418735 - Browse repository at this point
Copy the full SHA 4418735View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60bc52e - Browse repository at this point
Copy the full SHA 60bc52eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c526e92 - Browse repository at this point
Copy the full SHA c526e92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 556ad5f - Browse repository at this point
Copy the full SHA 556ad5fView commit details -
Use Rails conventions for ActiveRecord
where
s andorder
sWhen using `where` with a `joins`, you can reference the the join table as a key in a hash in `where`. Updated `Mailboxer::Receipt`, `Mailboxer::Notification`, and `Mailboxer::Conversation` to use this convention where possible. Also use a symbol and/or a hash for `order` where applicable.
Configuration menu - View commit details
-
Copy full SHA for 9ea3d34 - Browse repository at this point
Copy the full SHA 9ea3d34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 074c088 - Browse repository at this point
Copy the full SHA 074c088View commit details
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.