Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] remove deprecated #[clap] attribute #1298

Open
greged93 opened this issue Aug 11, 2024 · 1 comment · May be fixed by #1898
Open

[feat] remove deprecated #[clap] attribute #1298

greged93 opened this issue Aug 11, 2024 · 1 comment · May be fixed by #1898
Labels
good first issue Good for newcomers rust Pull requests that update Rust code

Comments

@greged93
Copy link

greged93 commented Aug 11, 2024 •
edited
Loading

I noticed a lot of the binaries use one of the deprecated #[clap(…)] attribute for parsing of the arguments. The latest documentation barely refers to it and it seems to have been deprecated since version 4.x of clap in favour of #[arg(…)] or #[command(…)].

I’d be willing to submit a PR if this feature is accepted.
@greged93 greged93 changed the title feat: remove deprecated #[clap] attribute [feat] remove deprecated #[clap] attribute Aug 11, 2024
@nhtyy nhtyy added good first issue Good for newcomers rust Pull requests that update Rust code labels Nov 19, 2024
@ilyaaay
Copy link

ilyaaay commented Dec 10, 2024

Hello. I want to take this issue.

@crStiv crStiv linked a pull request Dec 24, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove deprecated #[clap] attribute crStiv/sp1
3 participants
@nhtyy @ilyaaay @greged93