Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security identifiers are not validated #103

Open
freaz opened this issue Apr 3, 2023 · 0 comments
Open

Security identifiers are not validated #103

freaz opened this issue Apr 3, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@freaz
Copy link
Member

freaz commented Apr 3, 2023

Security identifiers are not validated.

Expected Behavior

Security Identifier is validated according to specification https://github.com/superfaceai/spec/blob/main/spec/latest/provider-spec.yaml#L65

Current Behavior

Resulting json-schema doesn't have pattern defined https://github.com/superfaceai/ast-js/blob/main/src/interfaces/providerjson/providerjson.schema.json#L59

Possible Solution

Not obligatory, but suggest a fix/reason for the bug

Steps to Reproduce

  1. create provider with security id foo-bar
@freaz freaz added the bug Something isn't working label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant