Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logback.xml not excluded in final jar artifact #1015

Open
matthieugeerebaert opened this issue Feb 22, 2022 · 1 comment · May be fixed by #1245
Open

logback.xml not excluded in final jar artifact #1015

matthieugeerebaert opened this issue Feb 22, 2022 · 1 comment · May be fixed by #1245

Comments

@matthieugeerebaert
Copy link

Hello,

is there a particular reason to not exclude logback.xml from final jar artifact like it is done with swagger-codegen for instance

https://github.com/swagger-api/swagger-codegen/blob/3.0.0/modules/swagger-codegen/pom.xml

        <resources>
            <resource>
                <directory>src/main/resources</directory>
                <excludes>
                    <exclude>logback.xml</exclude>
                </excludes>
            </resource>
        </resources>

I use it as a dependency ( maybe I am wrong ) and I suspect it changed our default logging configuration

https://github.com/swagger-api/swagger-codegen-generators/blob/master/src/main/resources/logback.xml

    <root level="error">
        <appender-ref ref="STDOUT"/>
    </root>
@Devdevlyo
Copy link

I agree, I always get
10:39:44,336 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Found resource [logback.xml] at [jar:file:/C:/Users/ac75095172/.m2/repository/io/swagger/codegen/v3/swagger-codegen-generators/1.0.27/swagger-codegen-generators-1.0.27.jar!/logback.xml] 10:39:44,336 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback.xml] occurs multiple times on the classpath. 10:39:44,336 |-WARN in ch.qos.logback.classic.LoggerContext[default] - Resource [logback.xml] occurs at [jar:file:/C:/Users/ac75095172/.m2/repository/io/swagger/codegen/v3/swagger-codegen-generators/1.0.27/swagger-codegen-generators-1.0.27.jar!/logback.xml]

sirlatrom added a commit to sirlatrom/swagger-codegen-generators that referenced this issue Jan 11, 2024
@sirlatrom
Delete src/main/resources/logback.xml
8681d5a 
Fixes swagger-api#1015.
@sirlatrom sirlatrom linked a pull request Jan 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete src/main/resources/logback.xml sirlatrom/swagger-codegen-generators
2 participants
@matthieugeerebaert @Devdevlyo