Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

Verison 0.3.3 generates files with the .undefined extension #287

Closed
Gamote opened this issue Jan 28, 2024 · 4 comments
Closed

Verison 0.3.3 generates files with the .undefined extension #287

Gamote opened this issue Jan 28, 2024 · 4 comments

Comments

@Gamote
Copy link
Contributor

Gamote commented Jan 28, 2024

I am using NestJS together with @swc/cli. This morning I have updated to the 0.3.3 from 0.3.2 and all the exported files are ending in the .undefined extension. For example what before was dist/src/main.js now it is dist/src/main.undefined.

I have rolled back to 0.3.2 and everything works as expected.

The bug must have been introduced in: 0e0d745

@Gamote
Copy link
Contributor Author

Gamote commented Jan 28, 2024

Found the issue, I am preparing a PR now.

@kdy1
Copy link
Member

kdy1 commented Jan 28, 2024

Should be fixed by v0.3.4

@Gamote
Copy link
Contributor Author

Gamote commented Jan 28, 2024

@kdy1 Thank you for the quick response.

v0.3.4 fixes the issue only if the consumer goes through the CLI.

If dir.ts is called directly, like many consumers do, we would experience the same issue, this is because prior v0.3.3 we had the default extension inside dir.ts. So event tho' I think it is better to pass the correct arguments when you interact with those files directly, I see it as breaking change.

Will this be something that you like: #288?

@kdy1
Copy link
Member

kdy1 commented Jan 28, 2024

Yeap, it's what I like

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants