Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not appear to call unmountComponentAtNode #5

Open
KMarshland opened this issue May 20, 2020 · 0 comments
Open

Does not appear to call unmountComponentAtNode #5

KMarshland opened this issue May 20, 2020 · 0 comments

Comments

@KMarshland
Copy link

This library should call unmountComponentAtNode in order to fix a memory leak.

The react team states "This is important and often forgotten. Forgetting to call unmountComponentAtNode will cause your app to leak memory. There is no way for us to automatically detect when it is appropriate to do this work. Every system is different." (source)

This is necessary even though the element is removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant