Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] When adding PuP-Pack, as user if they want to reset #673

Open
Ltek opened this issue Dec 23, 2024 · 4 comments
Open

[Feature Request] When adding PuP-Pack, as user if they want to reset #673

Ltek opened this issue Dec 23, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Ltek
Copy link

Ltek commented Dec 23, 2024

When uploading a pack where a prior pack exists, would be great to have Studio ask if the user wants to reset the pack to defaults.
If pack changed authors and/or versions so the PUP files are very different where the old pup files are no longer relevant/working, Studio doesnt know.

@syd711
Copy link
Owner

syd711 commented Dec 23, 2024

"Reset" means here: delete the existing folder all files before extracting the new one, right?

@syd711 syd711 added the enhancement New feature or request label Dec 23, 2024
@Ltek
Copy link
Author

Ltek commented Dec 23, 2024

"Reset" means here: delete the existing folder all files before extracting the new one, right?

Yes, delete the entire folder. Sorry, I should have said that specifically.

@syd711
Copy link
Owner

syd711 commented Dec 28, 2024

I have added a cleanup task before the actual PUP pack installation now. This way, no old corpses should remain.
An additional warning is too much effort right now as I have to go through all asset types again for this type of check.

@syd711 syd711 added the fixed This issue is fixed but not yet shipped. label Dec 28, 2024
@Ltek
Copy link
Author

Ltek commented Dec 28, 2024

understood... basic delete-all then install just keeps it clean. In case the user customized the .pup's and PinUpPlayer.ini in the root, might be good to have a popup asking :: Overwrite; Do Not Overwrite; Backup then Overwrite?

@syd711 syd711 removed the fixed This issue is fixed but not yet shipped. label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants