[Bug] High score for Defender not sent (wrong score sent)

[gorgatron1]

Describe the bug

Wrong score sent for Defender -- default score but I have a real score.

To Reproduce

Now this may be operator error. I presume at one point I recorded the default score for Defender (2.5 million). Later I reset the nvram and scored a real score: 322,230.

I noticed I didn't have a score in VPin Mania for Defender but I knew I had a score for it:

The formatted list looks a little strange, but it has my initials for the #2 score so that should be good.

Here is the event log:

Nov 28, 2024, 10:25:21 PM [INFO] ******** Event Log Start **********
Nov 28, 2024, 10:25:22 PM [INFO] Resetted active game status
Nov 28, 2024, 10:25:22 PM [INFO] Executing table exit commands for 'Defender (Williams 1982) VPW 1.3 VR'
Nov 28, 2024, 10:25:22 PM [INFO] Starting 6000ms update delay before updating highscores.
Nov 28, 2024, 10:25:26 PM [INFO] Skipped highscore change event for "smb" because the no score change for rom 'smb' detected.
Nov 28, 2024, 10:25:28 PM [INFO] Finished 6000ms update delay, updating highscores.
Nov 28, 2024, 10:25:28 PM [INFO] Calculated changed positions for 'dfndr_l4': 1
Nov 28, 2024, 10:25:28 PM [INFO] Created highscore version for Defender (Williams 1982) VPW 1.3 VR, changed position 1
Nov 28, 2024, 10:25:28 PM [INFO] Queued Notification "Defender (Williams 1982) VPW 1.3 VR" (A new highscore has been created!)
Nov 28, 2024, 10:25:28 PM [INFO] No iScored update sent, because there is no iScored subscription for table "Defender (Williams 1982) VPW 1.3 VR"
Nov 28, 2024, 10:25:28 PM [INFO] Sending discord default notification for: Defender (Williams 1982) VPW 1.3 VR
Nov 28, 2024, 10:25:29 PM [INFO] Submitted VPinMania score VPin Mania Score for table 'Defender (Williams 1982) VPin Workshop (VPW) 1.3' (value: 2,500,000, account: 55, vpsId: MBZPVX6p, vpsVersionId: XJIqrWKHAC)
Nov 28, 2024, 10:25:29 PM [INFO] Saved updated highscore for Defender (Williams 1982) VPW 1.3 VR to Studio database.
Nov 28, 2024, 10:25:29 PM [INFO] Skipped card generation, no target screen set.

Sure enough I have a denied (correct) score in VPin Mania but it doesn't upload my actual score, I presume because it is lower than the submitted default score.

Ideally the default score would no longer be considered and it would upload the actual score. Of course you don't want people to keep re-uploading the default score, so it can't just be ignored completely :-)

[syd711]

Something is off there for sure, starting with the score parser. Thanks for the detailled report. I'll look into it.

[syd711]

I couldn't reproduce it. Is the error still there for you - even when you refresh the highscore?
Could you attach the nvram too?
I've noticed that I've hard coded the locale to "en" and removed this. Maybe this already helps.

[gorgatron1]

Oh sorry, I thought I attached the nvram -- I had grabbed it :-)

dfndr_l4.nv.zip

Yes, this persistent even when I refresh the high score.

[gorgatron1]

Here are two more that render the wrong way:

• Catacomb
• Black Pyramid

nvrams.zip

but these both posted scores (new scores from tonight), so this may be two separate issues:

• Defender score not posting
• unexpected formatting for scores
  • indeed this looks like a common issue for all SS games with single score, no initials

[syd711]

These single score issue is worrying me the most. I'm out of town a few days and will look into that next week.

[gorgatron1]

I managed to get a new high score and it rescanned:

Jan 16, 2025, 9:42:32 PM [INFO] ******** Event Log Start **********
Jan 16, 2025, 9:42:33 PM [INFO] Resetted active game status
Jan 16, 2025, 9:42:33 PM [INFO] Skipped card generation, no target screen set.
Jan 16, 2025, 9:42:33 PM [INFO] Executing table exit commands for 'Defender (Williams 1982) VPW 1.3 VR'
Jan 16, 2025, 9:42:33 PM [INFO] Starting 6000ms update delay before updating highscores.
Jan 16, 2025, 9:42:39 PM [INFO] Finished 6000ms update delay, updating highscores.
Jan 16, 2025, 9:42:39 PM [INFO] Calculated changed positions for 'dfndr_l4': 1, 2
Jan 16, 2025, 9:42:39 PM [INFO] Created highscore version for Defender (Williams 1982) VPW 1.3 VR, changed position 1
Jan 16, 2025, 9:42:39 PM [INFO] Ignored iScored highscore change, because no player set for this score.
Jan 16, 2025, 9:42:39 PM [INFO] Sending discord default notification for: Defender (Williams 1982) VPW 1.3 VR
Jan 16, 2025, 9:42:39 PM [INFO] Ignored tournament highscore change, because no player set for this score.
Jan 16, 2025, 9:42:39 PM [INFO] Created highscore version for Defender (Williams 1982) VPW 1.3 VR, changed position 2
Jan 16, 2025, 9:42:39 PM [INFO] Showing Notification "Defender (Williams 1982) VPW 1.3 VR" (A new highscore has been created!)
Jan 16, 2025, 9:42:39 PM [INFO] No iScored update sent, because there is no iScored subscription for table "Defender (Williams 1982) VPW 1.3 VR"
Jan 16, 2025, 9:42:39 PM [INFO] Sending discord default notification for: Defender (Williams 1982) VPW 1.3 VR
Jan 16, 2025, 9:42:39 PM [INFO] Showing Notification "Defender (Williams 1982) VPW 1.3 VR" (A new highscore has been created!)
Jan 16, 2025, 9:42:40 PM [INFO] Submitted VPinMania score VPin Mania Score for table 'Defender (Williams 1982) VPin Workshop (VPW) 1.3' (value: 2,500,000, account: 55, vpsId: MBZPVX6p, vpsVersionId: XJIqrWKHAC)
Jan 16, 2025, 9:42:40 PM [INFO] Saved updated highscore for Defender (Williams 1982) VPW 1.3 VR to Studio database.
Jan 16, 2025, 9:42:40 PM [INFO] Skipped card generation, no target screen set.

if I am reading that correctly it declined to post because VPin Mania already has a higher score -- which is true, but it was denied. Maybe the logic isn't taking that into account?

Here is the server side:

16-01 21:42:32.498 INFO  [/service/gameExit]d.m.v.s.f.FrontendStatusService - Received game exit event for D:\vpx\vPinball\visualpinball\Tables\Defender (Williams 1982) VPW 1.3 VR.vpx
16-01 21:42:32.508 INFO  [/service/gameExit]d.m.v.s.g.GameService - Resource Game Event Handler resolved "Defender (Williams 1982) VPW 1.3 VR" for table name "D:\vpx\vPinball\visualpinball\Tables\Defender (Williams 1982) VPW 1.3 VR.vpx"
16-01 21:42:33.076 INFO  [Game Exit Thread [Defender (Williams 1982) VPW 1.3 VR]]d.m.v.c.m.RestClient - HTTP GET https://www.vpin-mania.net/api/cabinet (567ms)
16-01 21:42:33.281 INFO  [Game Exit Thread [Defender (Williams 1982) VPW 1.3 VR]]d.m.v.c.m.RestClient - HTTP POST api/cabinet/update (204ms)
16-01 21:42:33.283 INFO  [FX Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.c.CardService - Skipped card generation, no target screen set.
16-01 21:42:33.283 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.DefaultTableAndFrontendStatusChangeListenerImpl - Executing table exit commands for 'Defender (Williams 1982) VPW 1.3 VR'
16-01 21:42:33.283 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.DefaultTableAndFrontendStatusChangeListenerImpl - Starting 6000ms update delay before updating highscores.
16-01 21:42:39.285 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.DefaultTableAndFrontendStatusChangeListenerImpl - Finished 6000ms update delay, updating highscores.
16-01 21:42:39.285 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.r.u.SystemCommandExecutor - System Command: D:\vpx\VPin-Studio\.\resources\pinemhi> cmd.exe /c PINemHi.exe dfndr_l4.nv
16-01 21:42:39.351 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.p.n.NvRamOutputToScoreTextConverter - Converted score using SinglePlayerScoreAdapter
16-01 21:42:39.353 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Defender (Williams 1982) VPW 1.3 VR: Calculated changed score [#1 #1    370,800] has beaten [#1 #1    322,230]
16-01 21:42:39.353 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Defender (Williams 1982) VPW 1.3 VR: Calculated changed score [#2 David Koski   370,800] has beaten [#2 David Koski   322,230]
16-01 21:42:39.353 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Calculated changed positions for 'dfndr_l4': [1, 2]
16-01 21:42:39.358 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Created highscore version for Defender (Williams 1982) VPW 1.3 VR, changed position 1
16-01 21:42:39.436 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.f.n.NotificationStageService - Polling notifications (Queue size: 1)
16-01 21:42:39.436 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.i.IScoredHighscoreChangeListener - Ignored iScored highscore change, because no player set for this score.
16-01 21:42:39.437 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.HighscoreChangeListenerImpl - Skipped dynamic subscription updates, because they are not enabled.
16-01 21:42:39.437 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.HighscoreChangeListenerImpl - Sending discord default notification for: Defender (Williams 1982) VPW 1.3 VR
16-01 21:42:39.438 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.t.TournamentsHighscoreChangeListener - Ignored tournament highscore change, because no player set for this score.
16-01 21:42:39.442 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Created highscore version for Defender (Williams 1982) VPW 1.3 VR, changed position 2
16-01 21:42:39.471 INFO  [FX Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.f.n.NotificationStage - Window Mode: Portrait
16-01 21:42:39.479 INFO  [FX Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.f.n.NotificationStageService - Showing Notification "Defender (Williams 1982) VPW 1.3 VR" (A new highscore has been created!)
16-01 21:42:39.516 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.f.n.NotificationStageService - Polling notifications (Queue size: 1)
16-01 21:42:39.519 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.i.IScoredHighscoreChangeListener - No iScored update sent, because there is no iScored subscription for table "Defender (Williams 1982) VPW 1.3 VR"
16-01 21:42:39.520 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.HighscoreChangeListenerImpl - Skipped dynamic subscription updates, because they are not enabled.
16-01 21:42:39.520 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.l.HighscoreChangeListenerImpl - Sending discord default notification for: Defender (Williams 1982) VPW 1.3 VR
16-01 21:42:39.829 INFO  [FX Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.f.n.NotificationStage - Window Mode: Portrait
16-01 21:42:39.830 INFO  [FX Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.f.n.NotificationStageService - Showing Notification "Defender (Williams 1982) VPW 1.3 VR" (A new highscore has been created!)
16-01 21:42:40.082 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.m.RestClient - HTTP GET https://www.vpin-mania.net/api/cabinet (562ms)
16-01 21:42:40.265 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.m.RestClient - HTTP GET https://www.vpin-mania.net/api/denylist/MBZPVX6p (183ms)
16-01 21:42:40.456 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.m.RestClient - HTTP POST api/account/search (191ms)
16-01 21:42:40.634 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.c.m.RestClient - HTTP POST api/highscore/submit (178ms)
16-01 21:42:40.635 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.t.TournamentsHighscoreChangeListener - Submitted VPinMania score VPin Mania Score for table 'Defender (Williams 1982) VPin Workshop (VPW) 1.3' (value: 2,500,000, account: 55, vpsId: MBZPVX6p, vpsVersionId: XJIqrWKHAC)
16-01 21:42:40.637 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Saved updated highscore for Defender (Williams 1982) VPW 1.3 VR to Studio database.
16-01 21:42:40.638 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Highscore Service read 231 highscore text files
16-01 21:42:40.643 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.HighscoreService - Highscore Service read 228 VPReg.stg entries
16-01 21:42:40.644 INFO  [FX Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.h.c.CardService - Skipped card generation, no target screen set.
16-01 21:42:40.649 INFO  [Card Generator Thread for Defender (Williams 1982) VPW 1.3 VR]d.m.v.s.g.GameService - Saved event log for 699

[syd711]

Good news! Thanks to @leprinco we finally managed to reproduce the issue.
We are working on a fix.

[leprinco]

@gorgatron1 can you please look at the settings and tell us what is the value for you of the Highscore Leader Titles ?

If it contains "HIGHEST SCORES", please remove it

Just have in mind this is for the formatting only, when it comes to denied score, another fix is needed

[gorgatron1]

Yes, per #718 I did have "HIGHEST SCORES". With that removed it does seem to format correctly:

Thanks!

[syd711]

Fixed with 3.12.4